Use unified API for prompt voice agents - #9634

cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/map_voice_test.go:250

• [azd-code-reviewer] These unchecked assertions can panic when the generated wire shape changes, hiding which field is malformed. Guard each decoded JSON level so the test fails with a localized diagnostic instead.

	definition := wire["definition"].(map[string]any)
	audio := definition["audio"].(map[string]any)
	output := audio["output"].(map[string]any)

cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent.go:2334

• [azd-code-reviewer] The new create/update decision tree is not covered by the added tests. The client tests verify each HTTP method in isolation, but they would not catch regressions where a 404 updates, a 200 creates, or a non-404 GET error is ignored. Add orchestration tests for successful GET, 404, and another error status, asserting which follow-up request is issued.

	remoteAgent, getErr := agentClient.GetVoiceAgentUnified(
		ctx, request.Name, agent_api.AgentEndpointAPIVersion, overriddenHost,
	)
	if getErr == nil && remoteAgent != nil {
		progress("Updating voice agent using unified API")

cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent.go:2186

• [azd-code-reviewer] This new os.Getenv input is missing from the canonical environment-variable reference. cli/azd/docs/environment-variables.md is the source of truth and already has an azure.ai.agents section; add AZURE_VOICE_AGENT_API there with its accepted values, precedence, and legacy default so the README and reference do not drift.

		mode = strings.TrimSpace(os.Getenv(voiceAgentAPIEnvKey))

cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/map_voice_test.go:250

• azd-code-reviewer: These unchecked assertions turn an unexpected serialized shape into a package-stopping panic instead of a useful test failure. Guard each lookup and type assertion before descending into the next map.

	definition := wire["definition"].(map[string]any)
	audio := definition["audio"].(map[string]any)
	output := audio["output"].(map[string]any)

cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent.go:2334

• azd-code-reviewer: The core 200-vs-404 dispatch is not exercised by automated tests. The added client tests verify each HTTP method independently, so a regression that selects update after a 404, creates after a 200, or mutates after another GET failure would still pass. Add table-driven coverage around this branch for 200, 404, and non-404 failures.

	remoteAgent, getErr := agentClient.GetVoiceAgentUnified(
		ctx, request.Name, agent_api.AgentEndpointAPIVersion, overriddenHost,
	)
	if getErr == nil && remoteAgent != nil {
		progress("Updating voice agent using unified API")

cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/map_voice_test.go:250

• azd-code-reviewer: Guard these JSON map assertions so a malformed wire shape reports the failing level instead of panicking before the field assertions run.

	definition := wire["definition"].(map[string]any)
	audio := definition["audio"].(map[string]any)
	output := audio["output"].(map[string]any)

cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent.go:2220

• azd-code-reviewer: ENDPOINT is not a reliable final-write marker on redeploy because an existing value is never cleared. If the agent name changes and persisting NAME or VERSION fails, both isDeployed and Endpoints still accept the stale endpoint and direct users to the previous agent despite the failed deployment. Clear the marker after the remote operation succeeds, then write the new endpoint last.

	for _, envVar := range []struct{ key, value string }{
		{fmt.Sprintf("AGENT_%s_NAME", serviceKey), agentObject.Name},
		{versionKey, versionValue},
		{fmt.Sprintf("AGENT_%s_ENDPOINT", serviceKey), baseEndpoint},

Previously missed (2) — in code that hasn't changed since the last review.

cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/map.go:604

• azd-code-reviewer: Script-bearing Azure locales are serialized incorrectly. For example, the valid Azure voice az-Latn-AZ-BanuNeural is classified as OpenAI by azureNeuralVoicePattern, while this split would derive only az-Latn rather than az-Latn-AZ. The unified payload then omits or corrupts voice_locale and lowercases the voice name. Update both the Azure classifier and locale extraction to support BCP-47 script subtags, and add a script-locale test.

func voiceWireLocale(voice *agent_api.VoiceConfig) string {
	if voice == nil || voice.Name == "" || isOpenAIVoice(voice.Name) {
		return ""
	}
	parts := strings.SplitN(voice.Name, "-", 3)
	if len(parts) < 2 {
		return ""
	}
	return parts[0] + "-" + parts[1]

cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent.go:2279

• azd-code-reviewer: A non-404 failure from the preliminary GET is returned as OpCreateAgent, although no create request was attempted. ServiceFromAzure embeds this operation in both the user-visible message and telemetry code, so an outage or authorization failure is misleadingly reported as create_agent. Add an OpGetAgent operation and return it for this branch.

	shouldUpdate, decisionErr := shouldUpdateVoiceAgent(remoteAgent, getErr)
	if decisionErr != nil {
		return nil, exterrors.OpCreateAgent, decisionErr

cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent.go:2228

• azd-code-reviewer: This versioned voice deployment does not publish AGENT_<SERVICE>_PROJECT_ENDPOINT. validateFoundryAgentDependency requires that scope marker; its legacy fallback compares the new wss:// endpoint with the https:// project endpoint and therefore always fails. Any agent that declares this prompt-voice service in uses is still reported as not ready after a successful deploy. Persist the project endpoint before the final ENDPOINT marker, matching hosted-agent registration at service_target_agent.go:3295.

	for _, envVar := range []struct{ key, value string }{
		{fmt.Sprintf("AGENT_%s_NAME", serviceKey), agentObject.Name},
		{versionKey, versionValue},
		{endpointKey, baseEndpoint},

cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent.go:558

• azd-code-reviewer: This does not fully enforce ENDPOINT as the voice completion marker. A unified voice deploy writes NAME and VERSION before ENDPOINT; if the final write fails, the voice branch below is skipped, NAME/VERSION pass the hosted guard, and stale protocol endpoints from an earlier hosted configuration can be returned. Preserve the isVoice result and return CodeMissingAgentEnvVars whenever its base ENDPOINT is empty instead of falling through to hosted endpoint collection.

	// Voice agents (kind: prompt-voice) use the base ENDPOINT as their callable
	// endpoint and deploy completion marker, and unified deploys also record
	// VERSION. Gate the base-endpoint path on the service's actual declared
	// kind (resolved via the shared agentkind lookup, so this agrees with the
	// deploy path and next-step reader) rather than on the env-var shape: a hosted